Skip to content

Light Calorimetry #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lynnt20 wants to merge 82 commits into
base: develop
Choose a base branch
from
Open

Light Calorimetry #878

lynnt20 wants to merge 82 commits into from

Conversation

@lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Nov 19, 2025 •
edited
Loading

Description

Add producer module to create light calorimetry data products. Creates new subdirectory Calorimetry to store the module and fcls. Over 3 years since the first commit! Reco2/caf level changes only.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links

Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

lynnt20 added 30 commits January 10, 2023 23:58
@lynnt20
first build + commit
94c59df
@lynnt20
added root tree, more explicit cut parameters, and opflashes
08bd042
@lynnt20
first commit of light reco attempt using visibility map
fa2b8a7
@lynnt20
working version with reco/true comparisons
ccea7c6
@lynnt20
added backtracker info
afea365
@lynnt20
cleaned up trees, added wire assn, gamma weighted avg, true hit info
7ed0f0e
@lynnt20
clean up truth/reco hit information
31847f3
@lynnt20
add calibration constants for all planes
b119273
@lynnt20
use all hits instead of spacepoints->hits
55032e6
@lynnt20
clean up calorimetry cmakelists
fea4bf4
@lynnt20
calculate median as light estimate
477b63a
@lynnt20
removed unweighted fcl, added arapucas and noise threshold
eea4729
@lynnt20
fix tpc split bug, comitting debugging couts, add mean+median functions
081f01d
@lynnt20
cleanup
91ad097
@lynnt20
cleanup: remove hardcoded values, add fcl params
2e972c0
@lynnt20
Merge tag 'v09_67_00' into feature/lynnt_lightcalorimetry
ab13d13 
Version v09_67_00
@lynnt20
added verbose + skip truth validation fcl
5a0893c 
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
@lynnt20
added verbose + skip truth validation fcl
bd8b760 
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
@lynnt20
initial commit of producer module
bf0b0cc
@lynnt20
working version of producer module
8411be8
@lynnt20
cleanup, new functions, fcl parameters:
52c18df 
- moved truth validation to a separate function
- added lower/upper threshold for PE per channel
- added fcl param to turn on/off evaluating all planes
- option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet
@lynnt20
update output ttree, fix initialized/dummy ttree variables
a1df52b 
- merge the two previous trees into one
- match-type can now differentiate between event/slice level easily
@lynnt20
Merge tag 'v09_89_01' into feature/lynnt_lightcalorimetry
d21b784 
Version v09_89_01, patch release for SBN2024A
@lynnt20
switch to correct namespace for photon model, cleanup
16ce241
@lynnt20
update opdet efficiencies and simulation values
b791b51
@lynnt20
make working version of fcl without the analyzer
543c337
@lynnt20
update noise/non-linearity thresholds
2fc9be1
@lynnt20
small cleanup
6b59f8e
@lynnt20
Merge tag 'v09_93_01_02p02' into feature/lynnt_lightcalorimetry
07bdd70 
Version v09_93_01_02p02
@lynnt20
Merge tag 'v10_04_07' into feature/lynnt_lightcalorimetry
37a8831 
Version v10_04_07
@lynnt20 lynnt20 marked this pull request as ready for review January 21, 2026 23:11
@lynnt20 lynnt20 requested a review from linyan-w January 21, 2026 23:15
@linyan-w linyan-w moved this from Draft to Waiting on Reviewer in SBND 2025 Fall Production Jan 22, 2026
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
asanchezcastillo
asanchezcastillo reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@asanchezcastillo asanchezcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @lynnt20, this is a lot of great work! I just left some minor comments, mainly about fcl inheritance which I think is strongly recommended in this case.

@lynnt20
Copy link
Contributor Author

lynnt20 commented Jan 28, 2026

Thanks for all the comments and suggestions @asanchezcastillo !! I think I've addressed everything, let me know if you see anything else!

@linyan-w
Copy link
Contributor

linyan-w commented Jan 28, 2026 •
edited
Loading

Adding sim/reco group conveners for additional sign-off.
Please note that this is a new feature that is

  1. reco2 & downstream
  2. does not conflict with anything else

We will merge with any of the conveners sign-off on it from the physics & organization perspective. Lynn's CM presentation here:
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=44953

linyan-w
linyan-w reviewed Jan 28, 2026
View reviewed changes
ups/product_deps
Copy link
Contributor

@linyan-w linyan-w Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental inclusion of commits? Same for cmakelist one.

Copy link
Contributor Author

@lynnt20 lynnt20 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because the current version is out-of-date with the base branch; once we merge develop I think it should fix itself?

linyan-w
linyan-w approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One nitpicking comment: Is the Noise Threshold and Max Threshold unique to light calorimetry? If so great. Otherwise it would be nice to check that's the globally used values.

@lynnt20
Copy link
Contributor Author

lynnt20 commented Jan 28, 2026 •
edited
Loading

Looks good to me! One nitpicking comment: Is the Noise Threshold and Max Threshold unique to light calorimetry? If so great. Otherwise it would be nice to check that's the globally used values.

@linyan-w They are unique to this module, so no globally used values here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linyan-w linyan-w linyan-w approved these changes

@asanchezcastillo asanchezcastillo Awaiting requested review from asanchezcastillo

@henrylay97 henrylay97 Awaiting requested review from henrylay97

@justinjmueller justinjmueller Awaiting requested review from justinjmueller

@miquelnebot miquelnebot Awaiting requested review from miquelnebot

Assignees

@lynnt20 lynnt20

Labels

enhancement New feature or request

Projects

SBND 2025 Fall Production
Status: Waiting on Reviewer

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lynnt20 @linyan-w @asanchezcastillo @nathanielerowe